Skip to content

8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int' #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 23, 2025

Hi all,

This pull request contains a backport of commit d783a940 from the openjdk/jdk repository.

The commit being backported was authored by Boris Ulasevich on 22 Apr 2025 and was reviewed by Andrew Dinn.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332368 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int'

Issue

  • JDK-8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1913/head:pull/1913
$ git checkout pull/1913

Update a local copy of the PR:
$ git checkout pull/1913
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1913

View PR using the GUI difftool:
$ git pr show -t 1913

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1913.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d783a940988677dc91975f884adeaf9f047f7e07 8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int' Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2025

Webrevs

@bulasevich
Copy link

LGTM

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the undefined behavior reported by UBSAN, this change does not affect the current behavior. Risk is low.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@sendaoYan
8332368: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@sendaoYan The given argument, @GoeLin, is not a valid hash.

@sendaoYan
Copy link
Member Author

Thanks for the approved @GoeLin.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

Going to push as commit c19f86d.
Since your change was applied there have been 124 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2025
@openjdk openjdk bot closed this Jul 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@sendaoYan Pushed as commit c19f86d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants